Avoid warning from abc.collections#6562
Closed
ingenieroariel wants to merge 1 commit intoapache:v1-10-stablefrom
Closed
Avoid warning from abc.collections#6562ingenieroariel wants to merge 1 commit intoapache:v1-10-stablefrom
ingenieroariel wants to merge 1 commit intoapache:v1-10-stablefrom
Conversation
Member
|
I think it's better to have the PR to apache:v1-10-test @ingenieroariel -> we usually put everything in the v1-10-test (we cherry-pick changes there directly so sometimes it gets broken) - and only when we are readying for 1.10.* releases we move stable branch to the tip of v1-10-test. That would be easiest thing to do for us otherwise we have to compare stable/test branches. :). |
Member
|
Also v1-10-test branch is now quite ahead of v1-10-stable so you might want to use it as there are already some changes there. |
Member
|
This PR as written isn't suitable for inclusion in 1.10.x as collections.abc is not in Python2.7, and 1.10 still supports that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gets rid of warning in py3k